Fix bug that causes some trips to be dropped from parsed schedules.#52
Open
haileyplusplus wants to merge 1 commit intoBondify:masterfrom
Open
Fix bug that causes some trips to be dropped from parsed schedules.#52haileyplusplus wants to merge 1 commit intoBondify:masterfrom
haileyplusplus wants to merge 1 commit intoBondify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that reads raw GTFS data into dataframes doesn't have an explicit data type for service_id, requiring it to be inferred. In schedules with a mix of numeric and alphanumeric service ids, this can cause some to be read as numbers and some as strings, preventing joins from working properly. This change makes service_id values be from CSV as strings.
The following snippet should illustrate the issue for at least the next few weeks: