Skip to content

Fix document page obscured by the sidebar #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GetToSet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix document page obscured by the sidebar #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BoltFramework/BoltBrowserUI/Scenes/Browser/BrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public final class BrowserViewController: UIViewController, HasDisposeBag {
progressView = UIProgressView(progressViewStyle: .bar)
view.addSubview(progressView)
progressView.snp.makeConstraints { make in
make.top.leading.trailing.equalTo(view.safeAreaLayoutGuide)
make.top.leading.trailing.equalToSuperview()
make.height.equalTo(2)
}
}
Expand Down
18 changes: 9 additions & 9 deletions BoltFramework/BoltLookupUI/Scenes/Content/LookupContentViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ public final class LookupContentViewController: UIViewController, HasDisposeBag
view.addSubview($0)
$0.snp.makeConstraints {
$0.top.equalTo(view.safeAreaLayoutGuide)
$0.leading.trailing.bottom.equalToSuperview()
$0.bottom.equalToSuperview()
$0.leading.trailing.equalTo(view.safeAreaLayoutGuide)
}
}

Expand Down Expand Up @@ -257,15 +258,14 @@ public final class LookupContentViewController: UIViewController, HasDisposeBag

func updateScopeBarVisible(_ visible: Bool) {
scopeBar.isHidden = !visible
for childView in [browserViewController.view] {
childView?.snp.remakeConstraints { make in
if visible {
make.top.equalTo(scopeBar.snp.bottom)
} else {
make.top.equalTo(view.safeAreaLayoutGuide)
}
make.leading.trailing.bottom.equalToSuperview()
browserViewController.view.snp.remakeConstraints { make in
if visible {
make.top.equalTo(scopeBar.snp.bottom)
} else {
make.top.equalTo(view.safeAreaLayoutGuide)
}
make.bottom.equalToSuperview()
make.leading.trailing.equalTo(view.safeAreaLayoutGuide)
}
}

Expand Down