Conversation
jkloetzke
reviewed
Jan 27, 2026
recipes/libs/pcre.yaml
Outdated
| --enable-utf8 \ | ||
| --enable-unicode-properties | ||
| --enable-unicode-properties \ | ||
| --with-sysroot=$(${CC} --print-sysroot) |
Member
There was a problem hiding this comment.
Any chance you remember why this is needed? This is unusual because the compiler knows the sysroot by itself...
Contributor
Author
There was a problem hiding this comment.
Hmm...I removed it and it still compiles... 🤷
recipes/libs/libcap.yaml
Outdated
| @@ -1,4 +1,4 @@ | |||
| inherit: [make, install] | |||
| inherit: [make, install, 'basement::bits::libs'] | |||
Member
There was a problem hiding this comment.
Usually, the basement::bits:: classes are implementation details that should not be inherited by regular recipes. I'd suggest to use cpackage here.
recipes/libs/libcap.yaml
Outdated
| mkdir -p install | ||
|
|
||
| DYNAMIC=no | ||
| if basementBitsCrossCompiling; then |
Member
There was a problem hiding this comment.
Is it really about cross compilation or whether the library is built shared or static? In this case cpackageLibraryType (returns static/shared/both) is more appropriate...
recipes/libs/newlib.yaml
Outdated
Member
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.