feat(herdr): add bounded child agent panes - #9
Merged
Conversation
2 tasks
Main-line teardown now preflights the Herdr session presentation lock before destructive cleanup. Extend the bounded-child unit fixture so the fake CLI can resolve a case-local named-session socket and lock path.
Canonicalize temp paths for macOS /var vs /private/var parent discovery, isolate the Kimi HOME fallback from a host kimi on PATH, and pass the required ship delivery contract into the raw supported-harness spawn case.
…ing, add ready diagnostic
Bloh09
force-pushed
the
fm/fm-child-panes-pr
branch
from
August 10, 2026 15:28
6ce09d0 to
8a12e3b
Compare
CI saw ALL TESTS PASSED then EXIT trap failed with Directory not empty under remote-jobs when rm -rf raced a still-running worker. Wait for the worker pid (and process group) to die before deleting the temp root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Get the bounded child-panes landing PR green on the captain's fork (Bloh09/firstmate) by carrying the existing feature branch through the real no-mistakes pipeline.
Context and constraints:
What Changed
Risk Assessment
✅ Low: The bounded child-pane lifecycle is well-contained, preserves the required fail-closed teardown behavior, and includes behavior-oriented coverage for the introduced launch, ownership, delivery, and cleanup paths.
Testing
Diff checks, focused child/Herdr lifecycle tests, the real Herdr/Pi same-tab end-to-end flow, and teardown safety tests all passed; the evidence transcript demonstrates concurrent bounded panes, guarded operations, private completion, and exact cleanup. No screenshot was captured because the real terminal panes are intentionally destroyed by the lifecycle test, so the preserved end-user CLI transcript is the reviewer-visible artifact.
Evidence: Real Herdr child-pane lifecycle transcript
Two real Pi children ran concurrently in distinct panes within the parent Herdr tab, completed bounded edits, exercised safety refusals, and cleaned up without affecting the parent or control tab.Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
Inspectedgit diff --stat,git diff --name-only, andgit diff --checkfora2ba0efc7805e2b17b48d984c0e6d3713ac93fe0..6ce09d0f183c988c5623995fd4187d25508c64fc.bin/fm-test-run.sh tests/fm-child.test.sh tests/fm-backend-herdr.test.sh --json /var/folders/pb/bf5sf79j61bc37mnkt9kwt3h0000gn/T/no-mistakes-evidence/01KZN55M11B7G74VGTYM704RB2/focused-tests.jsonFM_CHILD_HERDR_E2E=1 FM_CHILD_E2E_POLLS=240 tests/fm-child-herdr-e2e.test.sh 2>&1 | tee /var/folders/pb/bf5sf79j61bc37mnkt9kwt3h0000gn/T/no-mistakes-evidence/01KZN55M11B7G74VGTYM704RB2/child-herdr-e2e.logbin/fm-test-run.sh tests/fm-teardown.test.sh --json /var/folders/pb/bf5sf79j61bc37mnkt9kwt3h0000gn/T/no-mistakes-evidence/01KZN55M11B7G74VGTYM704RB2/teardown-test.jsonVerifiedgit status --shortremained empty and checked for transient test artifacts in the worktree.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.