ci: add weekly cron job; add templates, contributing and codeowners #5
Open
gerau wants to merge 4 commits into
Open
ci: add weekly cron job; add templates, contributing and codeowners #5gerau wants to merge 4 commits into
gerau wants to merge 4 commits into
Conversation
KyrylR
requested changes
May 28, 2026
| on: | ||
| workflow_run: # zizmor: ignore[dangerous-triggers] | ||
| workflows: | ||
| - Sync compiler |
Collaborator
There was a problem hiding this comment.
Where is a sync compiler workflow?
| @@ -0,0 +1,35 @@ | |||
| name: Weekly Dependency Check | |||
Collaborator
There was a problem hiding this comment.
The workflow_run.workflows filter matches workflow names, so the issue-sync workflow will never trigger for this weekly check.
Comment on lines
+12
to
+13
| permissions: | ||
| issues: write |
Collaborator
There was a problem hiding this comment.
Suggested change
| permissions: | |
| issues: write | |
| permissions: | |
| issues: write | |
| actions: read |
| - name: Download Artifact | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: outdated-results |
Collaborator
There was a problem hiding this comment.
Suggested change
| name: outdated-results | |
| name: outdated-results | |
| run-id: ${{ github.event.workflow_run.id }} | |
| github-token: ${{ github.token }} |
| runs-on: ubuntu-24.04 | ||
|
|
||
| steps: | ||
| - name: Download Artifact |
Collaborator
There was a problem hiding this comment.
This downloads outdated-results without run-id or github-token, actions/download-artifact@v4 defaults to the current workflow run, not the completed upstream workflow, so this job will probably not find the artifact
| const parsedData = JSON.parse(rawData); | ||
| const dependencies = parsedData.dependencies; | ||
|
|
||
| const dep = dependencies[0]; |
Collaborator
There was a problem hiding this comment.
What if the list is empty?
Collaborator
Author
There was a problem hiding this comment.
add check for the dependencies
Collaborator
Author
|
applied suggested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds weekly job to check if current version of
simplicityhlcrate is the same as a stable version on crates.io. Not sure if that would work correctly, because I don't know how to properly test it.Also adds templates for issues, CONTRIBUTING.md and CODEOWNERS files