Repository navigation
bugfix: fix threading races and concurrency in moonrakerComm/RepeatedTimer - #211
Merged
Merged
Conversation
1 of 4 tasks
Member
|
Solid PR, solves a bunch of probable issues |
Signed-off-by: Guilherme Costa <guilherme.costa@blockstec.com>
…to bugfix/threading-concurrency
…, start timer under lock
1 of 4 tasks
gmmcosta15
added a commit
that referenced
this pull request
Sep 28, 2026
…tton (#339) # Description - [ ] Feature - [x] Bug fix - [ ] Code refactor - [ ] Documentation ConnectionPage now shows only while Klipper/Moonraker is down. It keeps retrying on its own and returns to the main window when Klipper is ready. The only buttons left are Restart Klipper and Restart Firmware. - Websocket: one retry timer every 3s with no cap, stopped only by an intentional disconnect. - Klippy: server.info is polled every 2s in any non-ready state with no cap. The state signal is sent only when the state changes, and the tracked state is reset on reconnect and on `notify_klippy_disconnected`. - Retry button removed from ConnectionPage. - mainWindow: removed the duplicate `klippy_state_signal` connection. - mainWindow: the automatic klipper service restart waits 15s in "disconnected", so a RESTART/SAVE_CONFIG or systemd's own restart (RestartSec=10) no longer triggers it. # Motivation After #211 the page froze: the websocket gave up after 3 attempts, and the Klippy poll stopped after 60s, which is shorter than Klipper's 90s MCU connect window. # Tests - Unit tests added for moonrakerComm, mainWindow and ConnectionPage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
connected,connecting,_reconnect_count,callback_tablefrom class-level to__init__to prevent shared state across instances._state_lock(RLock) and_request_lockguarding all reads/writes to those vars.params={}→params=Noneinsend_request.super()inOneShotTokenError._retry_timerwithNonecheck beforestopTimer/startTimer; stop existing timer intry_connectionbefore creating a new one (prevents orphaned threads).sendEvent→postEventfor safe cross-thread event delivery.json.loadsintry/except; use.get()on all external response dicts.join(timeout=self.timeout+1)on_wstto avoid indefinite block on shutdown.RepeatedTimer: invertedstopEventsemantics (set=stop,clear=running).Motivation
The WebSocket layer had multiple threading races and incorrect cross-thread event dispatch causing UI freezes and crashes on Pi hardware.
RepeatedTimerhad inverted stop-event logic causing timers to never stop correctly. These are the root-cause fixes for the most severe class of bugs in #200.