Skip to content

feat(scripts): landing classifier for clean-reviewed PRs (BLO-32240) #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkroo merged 3 commits into from
Sep 18, 2026
Merged

feat(scripts): landing classifier for clean-reviewed PRs (BLO-32240) #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cc6a70
feat(scripts): landing classifier for clean-reviewed PRs (BLO-32240)
Sep 13, 2026
e9d085d
fix(scripts): key Ally status exclusion on __typename, not name
Sep 13, 2026
1e08812
fix(scripts): key check dedup on surface, not name alone
Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,14 @@ jobs:
run: node --test ./scripts/check-ally-review-consistency.test.mjs
timeout-minutes: 1

- name: Test landing classifier
if: ${{ !cancelled() }}
# The classifier itself is not run here. It only ever reports in CI
# (`--apply` is opt-in) but it makes one `gh` call per open PR, and the
# routine that owns the live fire is BLO-32511.
run: node --test ./scripts/land-clean-prs.test.mjs
timeout-minutes: 1

- name: Test comment-review-gate census
if: ${{ !cancelled() }}
# The census itself is not run here: it fails on 100% of sampled merges
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-ally-review-consistency.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ function reviewDetails(reviews) {
return reviews.map((review) => `${reviewState(review)}/${review.id}`).join(", ");
}

function canonicalReviewHead(body) {
export function canonicalReviewHead(body) {
const text = String(body ?? "");
const headings = Array.from(text.matchAll(CANONICAL_REVIEW_HEADING_RE));
const attestations = Array.from(text.matchAll(ATTESTED_HEAD_GLOBAL_RE));
Expand Down
Loading