fix(recovery): preserve causal tails in failure summaries - #1600
Conversation
|
🔗 Paperclip issue: BLO-31142 |
|
Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 529d300
Looks good. The shared truncation helper preserves both the leading context and the causal tail while respecting the configured limit, and the focused regression tests cover the recovery and continuation-summary paths.
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Centralized truncation behavior avoids divergent implementations.
- Regression coverage verifies that long workspace failures retain their actionable cause.
Recommended Action
- No Critical or Important issues identified; merge when the required CI checks pass.
|
Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
Thinking Path
The existing failure-summary paths truncate from the head, allowing long workspace paths to hide trailing causes. A generic middle-elision helper preserves both context and diagnosis without git-specific branching.
The implementation keeps the existing caps and changes only over-limit formatting.
What Changed
Verification
git diff --checkpasses.529d300b7was found.Risks
The helper preserves the existing 240-character recovery-summary and 500-character continuation-error caps. Untruncated text remains byte-identical after trimming; only over-cap text changes from head truncation to middle elision.
Model Used
OpenCode / CTO implementation run.
Issue