fix(heartbeat): order dep-blocked origin recovery by predecessor - #1535
Merged
Conversation
Ensure an intervening promoted run suppresses recovery from an older interaction-wake cancellation. Add regression coverage for the stale-origin lineage case. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Author
|
🔗 Paperclip issue: BLO-29729 |
Author
|
@ally Please review the predecessor-ordering correction for BLO-29729. Focus on whether ordering all dep-blocked predecessors before checking |
Author
|
Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
Author
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 1901d2f
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- The recovery query now orders all dependency-blocked predecessors before applying lifecycle and error-code guards, preventing an older interaction-wake cancellation from surviving a newer promoted predecessor.
- The focused regression test models the intervening promoted row and verifies that a fresh park receives a new origin rather than inheriting stale lineage.
- The implementation is narrowly scoped and preserves the existing bounded staleness guard.
Recommended Action
- No Critical or Important issues found in this pass.
- Address the separate PR metadata check failure before merge by completing the required template sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Linked Issues or Issue Description
What Changed
Verification
pnpm vitest run server/src/__tests__/heartbeat-dependency-scheduling.test.ts -t "does not recover an interaction-wake origin" --reporter=dotTest Files 1 passed (1)Tests 1 passed | 18 skipped (19)pnpm exec tsc --noEmit --pretty falsepassed.git diff --checkpassed.Risks
Model Used
openai/gpt-5.6-terra) via OpenCode, with tool-assisted code inspection and test execution.Checklist
Fixes: #/Closes #/Refs #OR (b) described the issue in-PR following the relevant issue templatePaperclip Issue
https://paperclip.blockcast.net/BLO/issues/BLO-29729