fix(heartbeat): let manual wakes escape stale capacity parks (BLO-27141) - #1475
Merged
Conversation
|
🔗 Paperclip issue: BLO-27141 |
1 similar comment
|
🔗 Paperclip issue: BLO-27141 |
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: a76601b
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- The capacity-only supersession keeps ordinary scheduled retries on their existing coalescing path.
- The issue identity and legacy-owner checks cover the shared-task-key cancellation boundary, with focused concurrent-reprobe coverage.
- Cancellation records lifecycle and activity evidence while releasing stale ownership before the replacement wake is queued.
Recommended Action
- Merge when the remaining CI checks are green.
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 64701ed
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Manual capacity re-probes are narrowly scoped to explicit user wakes and preserve the existing scheduled-retry behavior for non-capacity paths.
- Issue-aware coalescing and conservative legacy task-key fallback prevent cross-issue cancellation, with concurrency and sibling-isolation coverage.
- Cancellation, ownership release, lifecycle events, and activity records are handled transactionally, with post-commit publication.
Recommended Action
- No Critical or Important issues found; approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Linked Issues or Issue Description
What Changed
manual_capacity_reprobe, plus durable lifecycle and activity audit records.Verification
pnpm exec vitest run server/src/__tests__/heartbeat-ccrotate-capacity-retry.test.ts --no-file-parallelism --maxWorkers=1— 20/20 passedpnpm --dir server typecheck— passedgit diff --check— passedorigin/masterbefore pushing.Risks
Model Used
gpt-5.6-sol, reasoning modexhigh, with tool use and code execution.Checklist