fix(github-webhook): route PR reviews through invokability (BLO-21582) - #1468
Merged
Conversation
1 similar comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 9978664
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Reviewer selection now uses the shared invokability contract while retaining explicit treatment for healthy paused reviewers versus invalid organization state.
- The availability retry is durable, bounded, and independently covered for recovery, long outages, malformed records, and duplicate marker deliveries.
- The PR-scoped advisory lock and enqueue coalescing path remain the single dispatch decision point.
Recommended Action
- Merge when the remaining CI gates pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Linked Issues or Issue Description
status: errorreviewer blackhole.What Changed
active,idle,running, anderrorreviewers are eligible.Verification
pnpm install --prod=falsepnpm --filter @paperclipai/server typecheckgit diff --checkpnpm exec vitest run server/src/__tests__/agent-invokability.test.ts server/src/__tests__/github-webhook.test.ts --reporter=dotROADMAP.md; this is a bug fix and does not duplicate roadmap work.Risks
errorstatus when the shared invokability contract says the agent and reporting chain remain callable; adapter recovery behavior remains owned by heartbeat dispatch.agent_wakeup_requestsrows and statuses are reused.Model Used
Checklist