fix(ci): make grandfathered attribution commits rebase-safe - #1357
Merged
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Author
|
🔗 Paperclip issue: BLO-27142 |
1 similar comment
Author
|
🔗 Paperclip issue: BLO-27142 |
11 tasks
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Author
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: f8ecc54
Critical Issues (0)
Important Issues (0)
Suggestions (1)
scripts/check-commit-author-attribution.test.mjs:23— Align the test helper'sgit showarguments with the production helper (--no-ext-diff --no-renames) so the fixture computes the same patch-id representation that CI enforces, including for rename-heavy commits.
Strengths
- The allowlist remains explicit and pairs each patch-id with the exact App author email.
- Local enforcement computes the patch-id from the checked-out commit while audit mode remains intentionally unallowlisted and historical.
- The rebase regression test verifies that the rewritten commit SHA is rejected while the registered stable patch-id is accepted.
Recommended Action
- Consider the test-helper alignment suggestion opportunistically.
- No Critical or Important issues block merge.
Author
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 9069238
Critical Issues (0)
Important Issues (0)
Suggestions (1)
scripts/check-commit-author-attribution.test.mjs:23— Align the test helper'sgit showarguments with the production helper (--no-ext-diff --no-renames) so the fixture computes the same patch-id representation that CI enforces, including for rename-heavy commits.
Strengths
- The allowlist remains explicit and pairs each patch-id with the exact App author email.
- Local enforcement computes the patch-id from the checked-out commit while audit mode remains intentionally unallowlisted and historical.
- The rebase regression test verifies that the rewritten commit SHA is rejected while the registered stable patch-id is accepted.
Recommended Action
- Consider the test-helper alignment suggestion opportunistically.
- No Critical or Important issues block merge.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Linked Issues or Issue Description
Refs: BLO-27142
What Changed
Verification
node --check scripts/check-commit-author-attribution.mjsnode --test scripts/check-commit-author-attribution.test.mjs(28 tests,28 pass,0 fail)gh api repos/Blockcast/paperclip/rulesets/20487141 --jq '{name,enforcement,conditions,rules}'returned activemerge_method: REBASE.git diff --checkRisks
Model Used
OpenAI GPT-5.6 Terra (
openai/gpt-5.6-terra), tool-using coding agent with repository inspection, GitHub API access, and local test execution.Checklist
Fixes: #/Closes #/Refs #OR (b) described the issue in-PR following the relevant issue templatePaperclip issue: https://paperclip.blockcast.net/BLO/issues/BLO-27142