feat(liveness): record GitHub PR work-product progress (BLO-19566) - #1247
feat(liveness): record GitHub PR work-product progress (BLO-19566)#1247kkroo wants to merge 1 commit into
Conversation
Persist trusted GitHub pull-request work products for linked issues, surface eligible PR progress in productivity evidence, and reconcile same-second lifecycle ambiguity against GitHub state. Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
🔗 Paperclip issue: BLO-19566 |
1 similar comment
|
🔗 Paperclip issue: BLO-19566 |
|
Closing as stale — this draft can no longer be landed as a diff. Measured against master
At that distance the surrounding code has moved out from under the patch, so "resolve the conflicts" would mean rewriting it against a codebase it was never written for — not merging it. Reopening is cheap if the branch is still wanted; the commits are untouched. Closing the PR does not close the underlying issue. Where this PR referenced a BLO issue, that issue remains the record of intent and the place to re-implement from, against current master. No judgement here on whether the original problem still exists — I did not verify that per-PR, and it should be re-checked before any re-implementation, since some of these may already have been fixed independently. |
Thinking Path
Linked Issues or Issue Description
Refs #920, the App-authored predecessor. This is an independent
kkroosuccessor for its still-unmerged PR-work-product scope; it does not modify, close, or merge the original.Refs BLO-19566. The issue's remaining acceptance criterion is to make a referenced GitHub PR visible as trustworthy productivity evidence.
Duplicate search: current GitHub search finds only #920 and the already-merged related #905. Current master has no PR work-product mapper/service or external-identity migration. The generic Artifacts & Work Products roadmap item does not provide this equivalent implementation.
What Changed
pull_requestwork-product mapper and an external-identity unique index/migration that deterministically reconciles pre-existing duplicates before enforcing uniqueness.Verification
Run from this branch after rebasing onto
origin/masterat08b6f44916103b624744dff6453997f85e67265b:pnpm --filter @paperclipai/db typecheck pnpm --filter @paperclipai/server typecheck pnpm --filter @paperclipai/server exec vitest run \ src/__tests__/pull-request-work-products.test.ts \ src/__tests__/github-app-auth.test.ts --reporter=dot --silentPassed focused database-backed coverage:
Results: migration
1/1, productivity evidence12/12, webhook work products17/17, actor-provenance1/1, and mapper/GitHub App57/57passed.Risks
external_id, preserving their work-product records and recording the former identity in metadata before creating the partial unique index.Model Used
OpenAI Codex, GPT-5-based deployment (the exact deployment model ID and context window are not exposed in this environment), with reasoning, tool use, code execution, GitHub CLI inspection, and targeted test execution.
Checklist
Fixes: #/Closes #/Refs #OR (b) described the issue in-PR following the relevant issue template