[codex] ci: route builds to stable BuildKit cache owners - #1206
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Hey @kkroo! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 9d3565a
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Routes each build class to a stable BuildKit ordinal while preserving a bounded healthy-Service fallback.
- Covers both server and agent workflows and keeps their Buildx remote-driver contracts explicit.
- The focused cache-routing contract test passes against the reviewed head.
Recommended Action
- No blocking changes requested.
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 9d3565a
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Routes each build class to a stable BuildKit ordinal while preserving a bounded healthy-Service fallback.
- Covers both server and agent workflows and keeps their Buildx remote-driver contracts explicit.
- The focused cache-routing contract test passes against the reviewed head.
Recommended Action
- No blocking changes requested.
9d3565a to
3644848
Compare
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 3644848
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Routes server and agent image builds to stable StatefulSet-local BuildKit cache owners while preserving a bounded ready-Service fallback.
- Keeps the remote Buildx endpoint selection explicit and validates both workflow contracts.
- Maintains the agent runtime smoke test on its local DinD daemon rather than conflating smoke execution with remote BuildKit.
Recommended Action
- No blocking changes requested.
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 3644848
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Routes server and agent image builds to stable StatefulSet-local BuildKit cache owners while preserving a bounded ready-Service fallback.
- Keeps the remote Buildx endpoint selection explicit and validates both workflow contracts.
- Maintains the agent runtime smoke test on its local DinD daemon rather than conflating smoke execution with remote BuildKit.
Recommended Action
- No blocking changes requested.
Thinking Path
Linked Issues or Issue Description
No dedicated issue exists. Repeated server and agent builds can land on different BuildKit cache owners even when their inputs are unchanged, causing avoidable cache misses and longer image builds. The expected behavior is stable cache ownership with bounded failover when an ordinal is unavailable.
Related implementation PRs found during deduplication: #1185 introduced persistent BuildKit, #1193 reduced export compression cost, and #1201 is the base of this stack.
What Changed
Verification
node --test scripts/__tests__/ci-cache-routing.test.mjsyq eval '.' .github/workflows/docker.ymlyq eval '.' .github/workflows/docker-agent.ymlgit diff --check origin/master..HEADRisks
Low operational risk. A preferred ordinal can be unavailable during rescheduling or cache recovery, in which case the workflow uses only ready Service endpoints. The probe checks TCP availability rather than executing a BuildKit request, but BuildKit opens port 1234 only after worker recovery in the deployed configuration. Reverting this commit restores the shared Service endpoint.
Model Used
OpenAI Codex, GPT-5 family coding agent with repository, shell, GitHub CLI, and Kubernetes tool access. The exact deployment model identifier and context-window size are not exposed to this session.
Checklist