Repository navigation
ci: run credential-free Linux jobs on ARC default - #197
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Nested CLI lenses applied directly inside the review pod.
Reviewed head: 311c924
Critical Issues (0)
Important Issues (1)
- [gstack/review + native-codex]
.github/workflows/packaging.yml:48— the diff moves thedockerjob todefaultand leavesgoreleaser(:187) onubuntu-latest. That is the reverse of what the PR description says ("goreleaser snapshot validation" moves; "the packaging Docker job … remain[s] on hosted runners because they use Docker, registry publishing").dockeris the job that, on everypush, readsHARBOR_USERNAME/HARBOR_PASSWORD, runsdocker login, and onmain/v*pushesregistry.blockcast.net/blockcast/go-amt/blockcast-shreds. So this change puts the secrets-bearing publish lane on the self-hosted pool, which the description explicitly says it should not do, while the credential-freegoreleaserlane stays hosted.- If the description is right: revert
:48toubuntu-latestand set:187todefault. Confirm the ARCdefaultimage shipsfile, which the "Release binary is static" step at the end ofgoreleaserrelies on. - If the move is intentional: update the description and confirm that running a Harbor-push lane on
defaultis acceptable. Org precedent exists (frr,trafficcontrolrundocker/build-push-actionondefault), so this is a scope/intent question, not a capability one.
- If the description is right: revert
Suggestions (1)
- [pr-review-toolkit:code]
.github/workflows/soak.yml:45— the soak job ondefaultdepends onpython3(scripts/assert_rss_plateau.py),curland/proc/<pid>/status. It isworkflow_dispatch-only, so this PR's CI will not exercise it. Do one manual dispatch before relying on it, or note in the description that it has not been run on ARC yet.
Strengths
- Small, mechanical diff. Keeping
releaseand the OIDC-signing paths on hosted runners is the right boundary. - The
smokeandstatic-binarymoves are genuinely credential-free:go buildplus a shell smoke test, with no secrets and no registry access.
Recommended Action
- Address Important issues this cycle.
- Consider Suggestions opportunistically.
kkroo
force-pushed
the
ci/arc-default-residual-linux
branch
from
October 31, 2026 20:15
311c924 to
653ae99
Compare
Contributor
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex. Nested CLI lenses applied directly inside the review pod.
Reviewed head: 653ae99
Looks good. The job swap from the previous head is corrected, and the diff now matches the description.
Prior Findings Dispositioned (1)
- prior:311c924 important 1 — fixed —
.github/workflows/packaging.yml:50—docker(the Harbor login/push lane, which readsHARBOR_USERNAME/HARBOR_PASSWORDat:130-131) stays onubuntu-latest, and there is an explanatory comment at:48-49. The credential-freegoreleaserjob is the one that moved todefault, at:189. Agoreleasercheck-run at this head completedsuccessondefault, so thefiledependency in "Release binary is static" (:213-214) is available on the ARC image.
Critical Issues (0)
Important Issues (0)
Suggestions (1)
- [pr-review-toolkit:code]
.github/workflows/soak.yml:45— the soak job isworkflow_dispatch-only, so this PR's CI does not run it ondefault. It depends onpython3,curland/proc/<pid>/status. Dispatch it once on this branch before you rely on it.
Strengths
- The hosted/ARC boundary is now exact. Jobs that touch secrets, Docker, registries or OIDC stay hosted; pure
go buildand smoke jobs move. - The comment on
dockerexplains why this one job is an exception, so a later sweep is unlikely to move it by mistake.
Recommended Action
- No blocking changes requested.
- Merge once the remaining required CI checks finish green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move credential-free Linux jobs to the existing ARC
defaultpool:packaging.yml: static binary smoke and goreleaser snapshot validationstatic-binary.yml: Linux static binary buildsoak.yml: local loopback soak testThe packaging Docker job and release workflow remain on hosted runners because they use Docker, registry publishing, GitHub release permissions, and keyless OIDC signing.
Validation
defaultrunner label configurationgit diff --check