Repository navigation
release(mabr): bump route proxy to 0.2.1 - #31
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex (nested CLIs unavailable in the k8s pod; applied directly to the diff).
Reviewed head: c9dc35a
Looks good. One-line version bump of @blockcast/mabr-route-proxy 0.2.0 → 0.2.1 in packages/mabr-route-proxy/package.json:3; branch is 1 ahead / 0 behind main, so it releases exactly #29 and #30 as described.
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- No lockfile or in-source version constant under
packages/mabr-route-proxyto drift out of sync with the bump. publish-npm.ymljobpublish-mabrasserts the packed tarball version equals themabr-route-proxy-v*tag before publishing, so a mistyped post-merge tag fails closed rather than publishing the wrong version.
Recommended Action
- No blocking changes requested.
- Merge once the remaining required CI checks finish green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@blockcast/mabr-route-proxy0.2.0 -> 0.2.1 to release #30 (route cache hit and miss telemetry, BLO-49953) and #29 (resolve DS URLs against the DS root, scope the cache to the manifest). After merge, tagmabr-route-proxy-v0.2.1on the merge commit sopublish-npm.ymljobpublish-mabrpublishes.Local:
npm run buildok,npm test53/53 pass,npm pack --dry-run-> blockcast-mabr-route-proxy-0.2.1.tgz (8 files).Paperclip: BLO-49945