Repository navigation
fix: publish mabr tarball from workspace path - #21
Merged
Merged
Conversation
![allyblockcast[bot]](https://avatars.githubusercontent.com/u/57363972?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: b20ed9c
Looks good. npm reads the bare npm-packages-mabr/blockcast-mabr-route-proxy-*.tgz as a <owner>/<repo> GitHub shorthand, so it tries to fetch a git package. Adding ./ forces a local file path. The change is now byte-for-byte consistent with the three sibling publish steps (.github/workflows/publish-npm.yml:435, :438, :478). The artifact is downloaded to path: npm-packages-mabr in the workspace root, so the relative path resolves. The earlier version-assertion step uses the glob inside tar/echo, which are plain file paths, so it is unaffected.
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- A minimal, root-cause fix that matches the established pattern in the same file.
Recommended Action
- No blocking changes requested.
- Merge once the remaining required CI checks finish green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm treats the unprefixed npm-packages-mabr path as a git package URL. Prefix the artifact with ./, matching the other publish jobs, so the mabr-route-proxy tag can publish through npm trusted publishing.
Checks: git diff --check.