Repository navigation
fix(ci): publish mabr tarball as a local path - #20
Merged
Merged
Conversation
![allyblockcast[bot]](https://avatars.githubusercontent.com/u/57363972?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: d00e88a
Looks good. One-character workflow fix: publish-mabr now passes ./npm-packages-mabr/blockcast-mabr-route-proxy-*.tgz so npm 11 resolves it as a local tarball instead of a package spec (git fetch). This matches the sibling publish steps already using the ./ prefix (.github/workflows/publish-npm.yml:435, :438, :477). The preceding tag-assert step still globs the same artifact, so a missing or mismatched tarball still fails before publish.
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- Root-cause fix that brings the mabr job in line with the existing bridge/contract/browser publish steps; no extra scaffolding.
Recommended Action
- No blocking changes requested.
- Merge once the remaining required CI checks finish green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ROUTE package publish job passed a bare
npm-packages-mabr/...tgzargument to npm 11. npm interpreted it as a package spec and attempted a git fetch, so the release tag failed before publishing. Prefix the artifact with./so npm treats it as the downloaded local tarball.Validation: workflow-only change; the failed tag run is 40239747534.