Never invent agents in someone else's repository - #61
Merged
Merged
Conversation
Testing the path a reader actually takes: clone-free, `npx @blocksifr/pctr init && scan` in a normal Express app with no agents in it at all. PCTR reported 5 agents, 3 tools and a CRITICAL consequence on customers.delete, in the same format as a real finding. The only hint was one dim line during init that scrolls past. For a tool whose entire proposition is telling you what is really there, appearing to invent findings is the worst failure available. Anyone technical who tried the published quickstart on their own project would have concluded it was fabricating, and they would have been right. - init no longer writes the example when discovery finds nothing. It says no agents were found, names what it looks for, and points at --example. - The example is opt-in, and the manifest it writes is marked "example": true. - scan prints an unmissable banner for an example manifest, and refuses to render a scan at all when no agents are declared. - The shared Markdown report carries the same warning above anything that reads as a finding — that one travels into other people's pull requests. - The GitHub Action inherits the behaviour: a repository with no agents now produces an empty scan rather than a false report. 195 tests. Published as 0.1.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested the path a reader actually takes before we announce anything: no clone, just
npx @blocksifr/pctr init && scanin a normal Express app with no agents in it at all.It reported 5 agents, 3 tools and a CRITICAL consequence on
customers.delete— in the identical format as a real finding. The only hint was one dim line duringinitthat scrolls past.For a tool whose whole proposition is telling you what is really there, appearing to invent findings is the worst failure available. Anyone technical who tried our published quickstart on their own project would have concluded it fabricates — and they'd have been right.
Changes
initno longer writes the example when discovery finds nothing. It says no agents were found, names what it looks for (MCP servers; OpenAI, Claude, LangGraph, CrewAI, AutoGen, AGT declarations), and points at--example."example": true.scanprints an unmissable banner on an example manifest, and refuses to render a scan at all when no agents are declared.Before / after, same empty project
Discovery on a project that does have agents is unchanged — still finds the MCP tools and CrewAI agent in the fixture.
195 tests. Version bumped to 0.1.1 for publishing.
🤖 Generated with Claude Code