fix(audio-only-mode): prefer non-MCDN/P2P URLs to avoid 403 and DOMException on playback#2
Merged
GrassBlock1 merged 4 commits intomasterfrom Mar 17, 2026
Merged
Conversation
…lement Co-authored-by: GrassBlock1 <46253950+GrassBlock1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix audio-only mode request issues
fix(audio-only-mode): prefer non-MCDN/P2P URLs to avoid 403 and DOMException on playback
Mar 17, 2026
GrassBlock1
approved these changes
Mar 17, 2026
GrassBlock1
approved these changes
Mar 17, 2026
There was a problem hiding this comment.
Pull request overview
Fixes audio-only mode playback failures caused by selecting MCDN/P2P CDN URLs (which may be rewritten/intercepted by other scripts, leading to 403 and playback DOMExceptions) by improving URL selection and adding a guard for torn-down players.
Changes:
- Corrects the typing/handling of
backupUrl/backup_urlasstring[]and aggregates primary + backup URLs. - Prefers the first non‑MCDN/P2P URL using URL heuristics, with a warning fallback when only MCDN/P2P URLs are available.
- Adds a
video.isConnectedguard before assigningvideo.srcto avoid errors when the element is detached during async work.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot fix ESLint errors |
Co-authored-by: GrassBlock1 <46253950+GrassBlock1@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backupUrl/backup_urlhandling (correctly typed asstring[]arrays)DOMExceptionfrom detached video elements gracefully (checkvideo.isConnected)isMcdnOrP2pUrlcatch path to returntrue(treat unparseable URLs as bad/unknown)📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.