Skip to content

fix: resolve all issues assigned to Mercy60 (#364, #365, #375, #376) - #513

Merged
MaryammAli merged 3 commits into
BlockDash-Studios:mainfrom
mercy60:fix/mercy60-issues-364-365-375-376
Jul 29, 2026
Merged

fix: resolve all issues assigned to Mercy60 (#364, #365, #375, #376)#513
MaryammAli merged 3 commits into
BlockDash-Studios:mainfrom
mercy60:fix/mercy60-issues-364-365-375-376

Conversation

@mercy60

@mercy60 mercy60 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Closes #364, Closes #365, Closes #375, Closes #376

Changes

#364 — Refactor: split task orchestration from business logic

  • Created tasks/task-orchestrator.service.ts with scheduling, retry (exponential backoff + jitter), queue management, and execution history
  • Added maxRetries property to TaskEntity
  • Updated TaskModule to register orchestrator

#365 — Bug: submission attachment scanning

  • Added validateAttachment() with size/type/content-policy checks to SubmissionsService
  • Added scanContentPolicy() and validateAttachment() to SecurityService
  • Added contentPolicyViolation notification to NotificationsService
  • Added env config: MAX_ATTACHMENT_SIZE_BYTES, ALLOWED_ATTACHMENT_TYPES, ATTACHMENT_SCANNING_ENABLED
  • Updated SubmissionsModule to import SecurityModule

#375 — Bug: health checks miss dependency health

  • Created health/health.service.ts checking Redis and Database health (ok/degraded/unavailable)
  • Added isHealthy() to RedisService and DatabaseService
  • Updated HealthController to use HealthService for dependency-aware checks

#376 — Enhancement: readiness probes

  • Created health/health.module.ts
  • Added GET /health/ready and GET /health/live endpoints
  • Added isReady(), getQueueDepth(), getLastHeartbeat(), heartbeat() to JobsService
  • Registered HealthModule in AppModule
  • Added READINESS_PROBE_TIMEOUT_MS env config

Bug fixes

  • Fixed missing closing brace in redis.service.ts
  • Fixed broken submissions.service.ts (duplicate class declarations merged)
  • Fixed broken notifications.service.ts (duplicate imports, malformed constructor, missing closing braces)
  • Fixed config.module.ts (missing Joi import, wrong schema export name validationSchemacontractEnvSchema, dead inline schema now properly merged via .concat())
  • Removed duplicate export class AppModule {}

@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@mercy60 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@MaryammAli MaryammAli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryammAli
MaryammAli merged commit 9727f1b into BlockDash-Studios:main Jul 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants