feat(cli): add pull request checkout command - #50
Merged
Merged
Conversation
Owner
Review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crabcode pr <number>to fetch and checkout GitHub pull requests aspr/<number>Validation
cargo fmt --checkcargo checkcrabcode pr --helpsmoke testNotes
The full suite currently has 6 unrelated failures in discovery, compaction, jobs, and UI; 1408 tests pass.
Review:
yan-ad:feat/pr-command→Blankeos:mainMerge confidence: 4.5/5 — ready to merge based on targeted validation.
Reviewed candidate:
6345aae, including follow-up fixes in6611919. Small feature scope; no migrations required. The reproduced checkout safety, missing fork ref, and repeat-launch problems are fixed. Remote alias/collision handling is now covered too.Changes pushed
gh repo set-default. This prevents adding the fork from breaking subsequent interactive checkout through repository ambiguity.Checks performed
cargo check --lockedandcargo build --lockedpassed.cargo fmt --checkandgit diff --checkpassed, including pre-commit validation.crabcode pr --helpsmoke check passed./tmprepositories, without model prompts:/exitall passed.Remaining limits / regressions
gh repo set-default OWNER/REPO. The new code prevents creating that ambiguity; it deliberately does not guess the intended base in an already-ambiguous repository.Migrations
None. No database, configuration-file schema, credential, or dependency-format migration. The command intentionally changes checkout/remotes/upstream settings; the follow-up additionally records the confirmed GitHub default repository in local Git configuration before adding a remote. Git and authenticated
ghremain required.Merge checklist / confidence bumps
No additional manual launch test is needed to reproduce the evidence above. The remaining full-suite comparison is extra assurance, not an identified blocker. Confidence scores are judgments, not guarantees.