test: cover versionbits deployment info names#268
Open
iamdinhthuan wants to merge 1 commit into
Open
Conversation
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploymentinfo_testsunit-test suiteVersionBitsDeploymentInfoentry has a non-null, non-empty nameDeploymentName()against the metadata table so missing versionbits entries are caught before RPC code can construct invalid stringsContext
This adds regression coverage for the class of issue discussed in #123, where a missing versionbits deployment name could make
getblocktemplatefail withbasic_string::_M_construct null not valid.Verification
taproot_discarded's deployment name tonullptr;LD_LIBRARY_PATH=/home/thuan/miniconda3/envs/py311/lib src/test/test_BGL --run_test=deploymentinfo_testsfailed withmissing deployment name at index 1make -j2 -C src test/test_BGLLD_LIBRARY_PATH=/home/thuan/miniconda3/envs/py311/lib src/test/test_BGL --run_test=deploymentinfo_tests->No errors detectedgit diff --cached --checkBounty / payout
Submitting for the open Bitgesell PR bounty program (#32, #39, #81) if maintainers consider this eligible.
Payout if approved: USDT or USDC SPL on Solana:
6mL4QQwcwLmb9UX1PjHtRSQ8J3HazCeVSDdZdDVQGXJj.