Feat/notification toast system - #445
Open
Jumongweb wants to merge 7 commits into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #197
This PR tightens and clarifies the custom in-app notification flow by extracting system-event-to-toast mapping into a dedicated helper and adding focused coverage for the automatic level-up and quest-completion toast triggers.
What Changed
Added lib/notifications/system-toast-events.ts (line 1) to convert published system events into toast payloads.
Updated components/notifications/notification-provider.tsx (line 1) to use the shared mapper instead of inlining level-up and quest-complete toast creation logic.
Added tests/lib/notifications/system-toast-events.test.ts (line 1) to verify:level-up XP events produce Level up! You're now Level N
quest completion events produce Quest complete: [Quest Name] (+N XP)
Expanded lib/gamification/xp.test.ts (line 1) to verify awardXP() publishes a leveled-up agent.xp event when XP crosses a level threshold.
Expanded tests/quests.test.ts (line 1) to verify completeQuest() publishes a quest.completed event with the awarded XP payload.
Why
The app already had a custom notification provider and toast queue, but the automatic toast behavior was embedded directly inside the provider. Extracting that mapping gives us a single place to reason about how system events become UI toasts and makes the XP/quest notification path much easier to test and review in isolation.
This also makes the follow-up notification work cleaner as a standalone PR, independent of any earlier unmerged implementation branch.