feat(sdk-core): add getEddsaMPCv2RecoveryKeyShares helper#8918
Draft
vibhavgo wants to merge 1 commit into
Draft
Conversation
Decrypt both keycards in parallel, validate pub and rootChainCode separately with distinct errors, and surface a clear message when keycard material is missing or a v2 Argon2id envelope is detected. Adds 7 unit tests covering happy path, field validation, and pub/rootChainCode mismatch cases. Ticket: WCI-396
vibhavgo
force-pushed
the
WCI-396/sdk-core
branch
from
6c41269 to
2451c14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds and exports
getEddsaMPCv2RecoveryKeyShares— a standalone helper that decrypts both EdDSA MPCv2 reduced keycards in parallel, validates thatpubandrootChainCodematch independently, and returns typedBufferkey shares with the derivedcommonKeyChain.Ticket: WCI-396
Changes
Promise.allpubandrootChainCodewith distinct error messagesgetDecodedReducedKeyShareto surface a descriptive error for missing/malformed keycard fieldsisV2EnvelopeTest Plan
yarn run unit-test --scope @bitgo/sdk-core -- -- --grep "getEddsaMPCv2RecoveryKeyShares"— all 7 tests passCLOSES TICKET: WCI-396