feat(statics): change kava to new cosmos structure #7941
Conversation
| name = 'Kava'; | ||
| family = CoinFamily.KAVA; | ||
| explorerUrl = 'https://www.mintscan.io/kava/transactions/'; | ||
| addressPrefix = 'kava'; |
There was a problem hiding this comment.
Could you provide the source of these values?
There was a problem hiding this comment.
The values come from coin sandboxing report for kava, here is the PR for the same: coin-sandbox-pr
There was a problem hiding this comment.
As a general practice, first get approval and merge the sandbox pr before raising the statics PR.
There was a problem hiding this comment.
@abhijeet8986 As discussed, if we onboard Kava as a Cosmos coin while keeping KavaEVM as is, let’s avoid changing the existing EVM code and instead add new, separate code for this.
modules/statics/src/networks.ts
Outdated
| class Kava extends Mainnet implements CosmosNetwork { | ||
| name = 'Kava'; | ||
| family = CoinFamily.KAVA; | ||
| explorerUrl = 'https://www.mintscan.io/kava/transactions/'; |
There was a problem hiding this comment.
The explorer endpoints will also change.
There was a problem hiding this comment.
Kava explorer URLs are as follows:
Mainnet: https://www.mintscan.io/kava/tx/ — for Cosmos-native Kava transactions
Testnet: https://testnet.mintscan.io/kava-testnet/tx/ — for testnet transactions
Changed to above
abhijeet8986
force-pushed
the
COIN-7315-kava-sdk-support
branch
2 times, most recently
from
592acd1 to
8fc8dbf
Compare
abhijeet8986
force-pushed
the
COIN-7315-kava-sdk-support
branch
from
8fc8dbf to
e0a31d9
Compare
alextse-bg
left a comment
alextse-bg
left a comment
There was a problem hiding this comment.
not sure why the wallets team is ping on this as it doesn't seems like we own anything is statics. Deferring to eth-alt
TICKET: COIN-7315