fix: record Actions pull request creation as enabled - #29
Merged
Conversation
Companion to php-bin's configure-script fix: the workflow-permissions flag can_approve_pull_request_reviews also governs PR creation, which the autorelease consumer's readiness PRs require. Snapshot regenerated after restoring the live setting.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe admin state snapshot updates its capture timestamp and digest. It also enables ChangesAdmin state snapshot
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to Bigpixelrocket/php-bin#64. The workflow-permissions flag
can_approve_pull_request_reviewsgoverns the combined "create and approve pull requests" GitHub setting, and the autorelease consumer's readiness PRs require it. Re-running the configure script during the ruleset migration switched it off in both repos, which broke php-bin's watcher this morning and would have broken the next consumer run that needed to write a readiness record.Changes
docs/admin-state/mise-php-after.json: regenerated with php-bin'sscripts/snapshot-github-admin-stateafter restoring the live setting on this repo.The configure-script fix itself lives in php-bin, which owns that script.
Summary by CodeRabbit