refactor: drop the pre-rename operator control fallback - #23
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_eeada897-e652-4d5f-a5bf-77d06ba49e46) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe consumer now fetches only commit-pinned autorelease policy invariants. The workflow now reads only the renamed autorelease operator file. Tests remove legacy fallback coverage and validate the single policy URL. ChangesAutorelease path enforcement
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
PR #23 removed the policy invariants path fallback on the understanding that it was dead code. It was not, and the consumer workflow failed on main straight after the merge: ``` autorelease consumer rejected input: policy capture path is not published: https://raw.githubusercontent.com/bigpixelrocket/php-bin/2a9a100c701c3e1e769e8cab47e8c3af61e52d89/autorelease/policy-invariants.json ``` Policy captures do not read php-bin main. `POLICY_COMMIT_SELECTOR_URL` selects the most recent commit that touched `support-policy.json`, and the capture pins to that exact commit so the policy and its invariants always come from one reviewed state. That commit is still `2a9a100c` from 2026-07-27, which predates the maintenance to autorelease rename, so the invariants it publishes are at `maintenance/policy-invariants.json`. The rename never touched `support-policy.json`, so the selector never moved forward. This restores `fetch_first_url` and the two pinned invariants URLs. Behavior is identical to the state before #23. The only substantive change is the docstring, which now records the real condition for removing the fallback: a commit that touches `support-policy.json` landing after the rename, rather than php-bin main merging its rename, which already happened. The two operator control fallbacks that #23 also removed stay removed. Both read at php-bin main's tip, so they were genuinely unreachable. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved retrieval of policy information when the primary location is unavailable. * Added fallback support for legacy policy locations, helping releases continue when current paths return “not found” responses. * Preserved clear error handling for other retrieval failures. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
php-bin main now carries only .github/autorelease-operator.json, so both fallback branches are unreachable. Removes the fallback the rename PR said to drop once php-bin landed.
Summary by CodeRabbit