Skip to content

Refactor Fusion to New OpenPype Publisher#8

Closed
BigRoy wants to merge 6870 commits intodevelopfrom
fusion_new_publisher
Closed

Refactor Fusion to New OpenPype Publisher#8
BigRoy wants to merge 6870 commits intodevelopfrom
fusion_new_publisher

Conversation

@BigRoy
Copy link
Owner

@BigRoy BigRoy commented Sep 21, 2022

Brief description

Just opening this temporary PR to allow some early comments on the work in progress refactor.
Once this PR ynput#2769 is merged then we can open this PR as draft to OpenPype repository and continue there.

iLLiCiTiT and others added 30 commits September 7, 2022 15:39
Kitsu|Change: Drop 'entities root' setting.
Kitsu - sync_all_project - add list ignore_projects
…te-project-folders-to-pipeline

General: Move create project folders to pipeline
…llect-Resources-Path

Maya: Publishing data key change
…ollect-instances-error-when-publishing-a-retime

Hiero: retimed clip publishing is working
…dio-plugin

Global: making collect audio plugin global
…ainers_in_scene

# Conflicts:
#	openpype/tools/loader/model.py
Igniter: Fix status handling when version is already installed
LiborBatek and others added 20 commits September 20, 2022 17:04
…tegrate-Hero-Version-is-not-working

Fix - hardlink issue in integrate Hero
…sher-Project-search

TrayPublisher: added text filter on project name to Tray Publisher
(cherry picked from commit c902d7b)
- UIs have pretty much no delays so no need to print
OpenPype manager/containers don't use it so it's redundant in the code base.

class CreateOpenEXRSaver(LegacyCreator):

class CreateOpenEXRSaver(Creator):
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will likely be separated into a FusionCreator once it works and there's need for multiple savers - since this is the ONLY creator it's directly inheriting from openpype.pipeline.Creator for easy development.

Comment on lines 115 to 118
# TODO: move this to lifetime data or alike
# (Doing this before CreatedInstance.from_existing wouldn't
# work because `tool` isn't JSON serializable)
created_instance["tool"] = tool
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's been some discussion to potentially implement allowing non-serializable 'lifetime' data that is data for the instance that will remain as is for the current session - to e.g. allow storing a direct link the Fusion saver tool (= a node) that this instance was created for. That'd be a more direct correlation than storing tool.Name especially since Fusion can have multiple comps open and the logic always operating against the "current comp" otherwise you wouldn't know which 'comp' this tool belonged too, etc.

@BigRoy BigRoy changed the base branch from fusion_integration_v2 to develop September 21, 2022 21:21
@BigRoy BigRoy closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants