Repository navigation
v5.9.3: fix blank cards and charts on the simulation page - #137
Merged
Merged
Conversation
…ace in site/simpage.js) The guided sections started on a bare timer, but the page's own script parses the embedded release panels in its DOMContentLoaded handler. On a slow load the timer ran first, found no data and quit, leaving every card and chart below the headline blank. The start now waits for DOMContentLoaded while REL.data is empty. A domtest check covers the start line; version labels and cache keys bumped to 5.9.3. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every card and chart below the headline on the simulation's main page (for example "How savings shift, and for whom") showed only its title on the live site.
Cause
site/simpage.jsis deferred and started on a bare timer. The page's own script parses the embedded release panels (REL.data) in its DOMContentLoaded handler. On a slow load the timer ran first, found no data and quit.Fix
Wait for DOMContentLoaded while
REL.datais empty (site/simpage.js). A domtest check covers the start line. Version labels and?v=cache keys bumped to 5.9.3 so browsers drop the cached 5.9.2 script. Engine block andharness.jsunchanged.Checks
validatepasses;unit384 tests;check_versionspasses.domtestis running in CI.Generated by Claude Code