Fix crash when viewing in-game documentation.#86
Open
harikattar wants to merge 1 commit intoBerry-Club:NeoForge-1.21from
Open
Fix crash when viewing in-game documentation.#86harikattar wants to merge 1 commit intoBerry-Club:NeoForge-1.21from
harikattar wants to merge 1 commit intoBerry-Club:NeoForge-1.21from
Conversation
This is probably the wrong way to handle it, but until OracleIndex fixes their mod this does make the documentation viewable without crashes.
Author
|
Relative links like this is how oritech works, and it's all one level deep so it may be that's the only thing OracleIndex was tested on. For example: |
|
Hi, oracle index dev here. This PR would be a solution to the issue. However I'm currently working on some changes to the wiki mod itself to also support these kinds of links. But I can't promise any eta yet. Just wanted to let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably will break out-of-tree documentation, it's just a demonstration of what a cleaned-up set of .mdx files would look like.
It may require that the .mdx files are post-processed after being copied. I wrote a python script for it but it could probably be done in a gradle-friendly way.
#85