Conversation
Owner
|
Thanks, will have a closer look and merge (within the next 1-2 weeks). I avoided "destroy", because on older hardware creating a new window did introduce some lag. But that was many years ago, your modification makes sense today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu 26 (and a few prior versions tested) rapidly pinning and unpinning a dockable panel leaves behind a dead/ghost panel.
Rough reproduction steps:
In practice the ghost appears to be an earlier painted snapshot of the intended panel we want to display. But its not intractable in any way directly. You can work around it by closing the live panel and displaying it again, which is odd, but the underlying issue seems to be X11 async event handling race conditions. On Windows Java/AWT interacts with the window system events are handled via a synchronous pipeline. But on Linux distros with X11, Java/AWT can't talk to the manager so it passes an async request through XWayland.
The main fixes are:
DefaultFlapWindow: An explicit call todestroy(which in turn disposes the window) when the window issetVisible(false).ScreenDockFrame: Added call toToolkit#sync()which eventually callsXlib#XSynx.Minor fixes:
window.setVisible( false );mitigated on my instance of Ubuntu 26.setFlapWindowhas a block which reads to me as removing the existing component, but it references the parameterwindowwhich would be the new content, and not the fieldthis.windowholding existing content.