Skip to content

Fix stale NumpySpec refs: add Benchmarks.MatrixDef shim; switch Dafny to dafnybench.Multiset; needs-based Lake targets#172

Draft
alok wants to merge 7 commits into
mainfrom
fix/alok-dafnybench-numpyspec
Draft

Fix stale NumpySpec refs: add Benchmarks.MatrixDef shim; switch Dafny to dafnybench.Multiset; needs-based Lake targets#172
alok wants to merge 7 commits into
mainfrom
fix/alok-dafnybench-numpyspec

Conversation

@alok
Copy link
Copy Markdown
Contributor

@alok alok commented Sep 9, 2025

Summary

  • Replace all Dafny imports of NumpySpec.DafnyBenchmarks.Multiset with dafnybench.Multiset.
  • Introduce lightweight Benchmarks.MatrixDef (Matrix/Array3 shims) per upstream git history (commit 5ea1204), and include it in BenchNumpySimple globs so numpy_simple specs can import it.
  • Retain green default build by composing sub-targets via and marking Benchmarks.Fast as default.

Rationale
Upstream vericoding history shows that the old NumpySpec modules were removed and numpy specs were updated to rely on a small helper (see 5ea1204) and Dafny specs were migrated off NumpySpec to a local Multiset stub. This PR applies those changes here.

Notes

  • numpy_simple files still contain many sorrys and shape/index placeholders, so BenchNumpySimple compilation will fail on type obligations; we keep it out of the default target.
  • Follow-ups: either soften the specs further or complete the shims for common matrix operations used in numpy_simple specs.

alok added 7 commits September 8, 2025 20:26
…add lean-lsp-mcp integration; fix determine_input_type; Lean verify via lake env lean; add sample + continuous runner
…scription when generating Lean; patch isinf doc string
…Multiset stub; keep default build green via needs-based sub-targets
… needs globs; resolve stale NumpySpec imports per upstream git history
@alok alok changed the title fix/alok dafnybench numpyspec Fix stale NumpySpec refs: add Benchmarks.MatrixDef shim; switch Dafny to dafnybench.Multiset; needs-based Lake targets Sep 9, 2025
alok added a commit that referenced this pull request Sep 10, 2025
- Add Benchmarks/MatrixDef.lean
- Update dafnybench Multiset stub and fix imports across users

This isolates only the .lean changes related to Multiset/Matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant