This repository was archived by the owner on Jul 11, 2024. It is now read-only.
adds promise callback to emebed plugin & adds url to the linkObject tooltip content - #52
Open
TomRibuot wants to merge 2 commits into
Open
adds promise callback to emebed plugin & adds url to the linkObject tooltip content#52TomRibuot wants to merge 2 commits into
TomRibuot wants to merge 2 commits into
Conversation
jdohuutin
reviewed
Mar 24, 2017
| }).catch(reason => { | ||
| if(reason.type !== 'cancel') { | ||
| throw reason; | ||
| } |
There was a problem hiding this comment.
C'est normal de throw dans le cas d'un reject? Ca risque pas de casser l'application?
Collaborator
Author
There was a problem hiding this comment.
Oui et non, ça lève une erreur mais l'application continue de tourner. Il n'y avait pas de mécanisme de gestion d'erreur à l'origine.
Le catch ici écoute un reject de toute la chaine de Promises; si la reason est un cancel (par exemple à la fermeture d'une modal) je ne throw rien, mais si ça vient d'autre part je pense qu'il est pertinent de throw
Peut être que l'attribut devrait se nommer autrement que type d'ailleurs
jdohuutin
approved these changes
Mar 24, 2017
jdohuutin
approved these changes
Mar 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.