Use core nav_tabs for the import preview entity tabs - #34
Open
mdon wants to merge 1 commit into
Open
Conversation
The strip was hand-rolled border tabs with per-entity count badges. The
payload key moves from `entity` to the component's standard `tab` (the
one test pushing that event updated with it). Inactive badges lose their
badge-ghost tone for the component's plain default — the active tab still
reads badge-primary.
Needs the core release carrying variant={:border}.
1125 tests, 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hand-rolled border tabs with per-entity count badges. The payload key moves from
entityto the standardtab(one test updated with it). Inactive badges tradebadge-ghostfor the component's plain default; the active tab still readsbadge-primary.Part of the underline-tab consolidation wave — companion to BeamLabEU/phoenix_kit#746, which this depends on.⚠️ Merge core first and release:
variant={:border}/ verbatim:patchneed the new core, so CI here stays red against Hex 2.13.5 until the release lands (same sequencing as the first wave).mix precommitgreen against local core; deployed to max-dev and verified.