Declare rustler explicitly so mdex_native force-builds - #42
Merged
Conversation
MDEX_NATIVE_BUILD=1 in this environment forces mdex_native to build its NIF from source (OTP 28 ships no precompiled build), which requires rustler itself, not just rustler_precompiled. mdex arrives here transitively through phoenix_kit; a clean checkout failed to compile without this. Same declaration phoenix_kit's own mix.exs already carries.
Contributor
Author
|
Ran the full suite on this branch tip: 866 tests, 0 failures (1 skipped). |
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDEX_NATIVE_BUILD=1forcesmdex_nativeto build its NIF from source when no precompiled build exists for the running OTP (28 in our case), which requiresrustleritself, not justrustler_precompiled.mdexarrives here transitively throughphoenix_kit; a clean checkout fails to compile without this declaration. Same declarationphoenix_kit's ownmix.exsalready carries.One fix, six repositories. Every module that pulls
mdextransitively throughphoenix_kitneeds the same one-line declaration, and each repository needs its own PR. Already merged: BeamLabEU/phoenix_kit_catalogue#77, BeamLabEU/phoenix_kit_billing#27. Still open: BeamLabEU/phoenix_kit_crm#25, BeamLabEU/phoenix_kit_warehouse#20, BeamLabEU/phoenix_kit_entities#35.Scope. This makes this repository build from a clean checkout under
MDEX_NATIVE_BUILD=1. It does not remove the need for a host application to declarerustleritself: optional dependencies of dependencies are never resolved, so whichever project is the root has to declare it.