Skip to content

perf remove window load - #32

Merged
ptesei merged 3 commits into
developfrom
feat/perf-remove-window-load
Aug 4, 2026
Merged

perf remove window load#32
ptesei merged 3 commits into
developfrom
feat/perf-remove-window-load

Conversation

@ptesei

@ptesei ptesei commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Low risk: front-end timing change is localized to FAQ accordion init; bump script only affects maintainer release tooling, not runtime site behavior.

Overview
Front-end FAQ accordions no longer wait for the full window load event (images, late assets). Initialization runs in an init() helper on DOMContentLoaded when the document is still loading, or immediately if the DOM is already ready—so interactive FAQ UI should appear sooner on the page.

Release workflow: Adds bin/bump-version.js and npm run bump -- <patch|minor|major|x.y.z> to bump semver consistently across .plugin-data, package.json, lockfile, block block.json files, blockparty-faq.php, readme.txt, CHANGELOG.md, and README.md (with dated TBD changelog stubs). /bin is excluded from distribution via .distignore and .gitattributes, and the README documents the new script.

Reviewed by Cursor Bugbot for commit 8680969. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8680969. Configure here.

Comment thread bin/bump-version.js
`Semantic Versioning intro in ${ relativePath }`
);

writeFile( relativePath, contents );

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog link refs

Medium Severity

updateChangelogMd inserts a Keep a Changelog heading like ## [x.y.z] but never adds the matching footer reference link that CHANGELOG.md already maintains for every prior release, so new version headings render as unresolved references.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8680969. Configure here.

Comment thread bin/bump-version.js
'## Changelog\n\n',
`## Changelog\n\n${ stub }`,
`Changelog heading in ${ relativePath }`
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README changelog order broken

Low Severity

updateReadmeMd always prepends the new entry under ## Changelog, but README.md currently lists versions oldest-first. Each bump therefore places the newest release above 1.0.0 and out of sequence with the existing history.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8680969. Configure here.

@ptesei
ptesei merged commit 492aafb into develop Aug 4, 2026
2 checks passed
@ptesei
ptesei deleted the feat/perf-remove-window-load branch August 4, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants