feat: Migrate logic to tree sitter parser#32
Draft
Batalex wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a big rework of the internals of craft-ls.
Craft-ls previously used pyyaml primitives to parse broken documents as best as we could. Turns out, having a broken document is not the exception but the norm when we develop a language server.
The biggest issue with the pyyaml approach is that it is a top-to-bottom parsing, meaning that editing the document in the middle discards half of it for the language server until we type enough characters to get a valid yaml file.
Parsing the document using tree sitter gives us a robust way of getting the content of the document by properly wrapping broken yaml syntax in error nodes.
We also have a solid foundation for adding our own linter rules later on