Fix/datatype uninterpreted sort#12
Merged
Merged
Conversation
When a Datatype constructor field uses an uninterpreted sort from DeclareSort, compileSort now auto-declares it as a Lean axiom instead of throwing "unknown uninterpreted sort". The Python side tracks which sorts have been declared so they aren't re-bound as ForAll type vars.
- Add ruff + mypy config to pyproject.toml and dev dependencies - Add lint CI job that runs before tests - Auto-format all Python files with ruff - Fix import sorting, unused imports, ambiguous variable names - Fix mypy errors in RealVal string parsing and SeqRef.at return type - Convert Union[] type aliases to X | Y syntax in _ast.py - Fix duplicate TestBugFixes class name in test_z3_compat.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Datatype constructor field uses an uninterpreted sort from
DeclareSort, compileSort now auto-declares it as a Lean axiom instead
of throwing "unknown uninterpreted sort". The Python side tracks which
sorts have been declared so they aren't re-bound as ForAll type vars.
Closes #9