update encoding_instructions to take in lexical context as a parameter
#518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranandcode
changed the title
enocding_instructions to take in lexical context as a parameterencoding_instructions to take in lexical context as a parameter
kiranandcode
requested review from
eb8680 and
jfeser
and removed request for
jfeser
eb8680
reviewed
Jan 28, 2026
Contributor
eb8680
left a comment
eb8680
left a comment
There was a problem hiding this comment.
Can you suggest and add some unit tests?
Contributor
Author
|
oh, yep will do! |
Contributor
Contributor
Author
could you give a code snippet to clarify? I'm still not entirely sure I have a good idea of what this idea is. As in t should be a type that supports .encoding_instructions? |
Contributor
Author
|
Subsumed by #521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving making it into an operation into another PR. Closes #516