Changelog for 1.2.4 - #19
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 3 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changelog adds Mapsicle 1.2.4 release notes. The notes document the EF Core upgrade, source-formatting changes, NuGet Trusted Publishing through OIDC, and two issues deferred to version 1.3.0. ChangesMapsicle 1.2.4 release documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a documentation-only changelog update, so no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Security release. Changelog only; the fix itself is already on
main.What actually ships
I diffed
src/from the 1.2.3 version bump (9a613f0) tomainrather than describing what I assumed changed. Ignoring whitespace, three files differ:The two
.cschanges aredotnet formatreorderingusingdirectives, verified as semantically identical. So this release contains exactly one substantive change.Why it is worth releasing on its own
Mapsicle.EntityFramework 1.2.3on NuGet declaresMicrosoft.EntityFrameworkCore 8.0.0(confirmed from the published nuspec, not from the csproj). That resolvesMicrosoft.Extensions.Caching.Memory 8.0.0, GHSA-qj66-m88j-hmgj, high severity. Every install of 1.2.3 and earlier inherits it, and the fix has been sitting merged and unreleased.Deliberately not bundled with #5 and #2. Those change behaviour: widening conversions that currently return
0will start returning values. Anyone taking this release for the advisory should not have to take a behaviour change with it.The changelog records both as known issues present in this release, with the detail that
inttoint?andinttointare unaffected, since that is what makes the bug easy to miss.Verification
main: 525 tests across 13 projects, 0 faileddotnet list package --vulnerable --include-transitiveclean across all 20 projectsVERSION="${GITHUB_REF_NAME#v}", applied as/p:Version=) and there is no<Version>inDirectory.Build.propsto conflict, sov1.2.4will publish 1.2.4Note for the record: the only existing tag is
v1.1.0while NuGet is at 1.2.3, because 1.2.3 shipped under the old push-to-main workflow.v1.2.4will be the first tag that matches a published version.Summary by CodeRabbit