Repository navigation
Desktop start failures and port changes, Browser Watch background lookups and settings, sound off, history axis - #1946
Merged
Conversation
… stops A deck that exits while starting ended the app's forty-second wait only when the forty seconds were up, and the tray then said "No deck running" with the reason left in deck-app.log. The wait now ends when the deck exits; its last log lines go into a dialog and the tray says the deck could not start. A launcher that cannot be written is a failed start rather than a rejection that skipped the rest of the app's startup, and Start the deck no longer starts a second deck after a failed one.
…p follows it openWindow fixed the window's origin from the deck's port once, and attaching to a deck on another port never touched the window, so the page retried the old port until it was closed and opened again, and its custom-sound calls were refused. An open window is now reloaded at the new deck's origin, and its two navigation handlers read the origin it shows rather than a copy taken at open.
With the watch on, the badge's five-minute background poll ran the whole browser survey, whose first step is a DNS lookup of the relay's address, though the poll reads only the episodes and the switch. That poll no longer surveys. The README now says what does go out: the relay lookup while the Browser Watch panel is open, and the machine panel's DNS lookup and TCP handshake to api.anthropic.com.
…inside the write queue The settings route read the store before the queue and wrote back the whole settings object built from that read, so a second one-field change whose read came before the first one's write put the first field back: switching the watch off and changing the reaction straight after left the watch on. The patch is now merged against the state the queue hands in, and the reply and the log line use what was written.
…is turned off M and the Sounds switch only wrote the flag down, so a spoken voice went on for up to half a minute after muting and an imported clip played to its end. The player keeps hold of the clips it starts and gains silence(), which cancels speech and stops them, and turning the sound off calls it.
…'s one time axis Each chart stretched across its own first and last point, so a series that started late or stopped early — the latency probe on a deck that could not reach Claude at first, a sensor that turned up late — drew the same minute at a different x from the charts above and below it. The dialog now hands every chart the span all of its series cover, the line, the fill, the marks, the hover and the clocks under each chart use it, and a series that was not measured for part of it leaves that part empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
api.anthropic.com. It no longer says nothing leaves the machine for Browser Watch.Verification
npm run typecheck: clean.development, the touched areas were run again: 79 files, 908 tests passed.desktop-deck-start-failure.test.ts: before the fix, the wait ran its full length after the deck exited (4.0 s against a 1.5 s bound), no reason was given, and a throwing start rejected. It also checks the tray line and the wiring in main.mjs.desktop-window-follows-deck.test.ts:originToFollowbehaviour, plusattach()reloading the window and the handlers reading the live origin.browser-watch-background-poll-dns.test.ts: before the fix, thelive=0poll with the watch on randig(the fixture records commands and runs none). The README cases failed on the old wording.browser-watch-settings-race.test.ts: before the fix,{enabled:false}followed by{reaction}while a poll held the queue leftenabled: true.sound-off-silences.test.ts: before the fix, a voice was still speaking and a clip still playing after the sound was turned off. Uses the real player and hook over fake audio and speech.section-history-one-time-axis.test.ts: before the fix, a 40-minute series under a 3-hour one started at the left edge (x 30 instead of 437.6), and the clocks under each chart differed.desktop-tray-menu.test.ts, the handlers' origin indesktop-window-links.test.ts, and the survey call inbrowser-watch.test.ts.speakingtrue → false).own-deck.mjs,tray-menu.mjs,nav.mjs) and main.mjs's wiring. Electron was not started.