Repository navigation
Network map key, heartbeat Retry-After, skipped-release tray row, and two narrow-topbar fixes - #1933
Merged
Merged
Conversation
The key under the network map listed "over Tailscale" on every network, including one with no deck on the tailnet and one where every deck is on it, where no slice is drawn. It is now told whether the slice was drawn, as the panel's note already is, and keeps the entry for a slice drawn without its name.
A 429 or 503 with a Retry-After held back the check-ins, but the ping still went on every beat, about every ten minutes. The wait the API asks for is now kept apart from the check-ins' own backoff and holds the ping as well, with the same one-day cap, whichever request it came back on.
After a macOS swap failed, that release is not staged again until a newer one is out, but the tray row read "Update failed — try again" and invited a retry that is refused the same way every time. The updater now marks that failure as a skipped release with its version, and the row reads "Skipped vX — check for the next release"; clicking it still checks.
From 481px all nine controls are back on the bar, and a selected agent's ribbon came back with them where even its floor does not fit: the readout gave first, so the waiting pill lost up to 5px of its left edge to 499px, and up to 15px to 520px with a running agent's cost, which ran on over the Session list button. Below 640px the detail sheet already names the agent, so the ribbon now leaves at that breakpoint instead of the ⋯ fold's.
The sheet hides the ⋯ above a phone's width, and a menu open across that line was placed against a box of zeros: it went to the window's top-left corner, still open and holding focus. A popover whose anchor stops being drawn now closes, as one whose anchor is gone already did, and the ⋯ hands focus to the button its focused item stands for, which the bar draws again.
This was referenced Oct 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
AnchoredPopoverwhose anchor stops being drawn now closes, as one whose anchor is gone already did. The ⋯ hands focus to the bar button that matches the focused menu item, now shown again.Verification
npm run typecheck: clean.--maxWorkers=3 --minWorkers=1): 884 files, 11560 tests passed, exit 0. After rebasing ontodevelopment(which brought in Close a dialog only on a press of its scrim #1932), the touched and neighbouring tests ran again and passed: 134 files, 1823 tests.network-map-legend-slice.test.ts: the key had four entries on a network with no tailnet deck, and on one with only tailnet decks.reports-ping-retry-after.test.ts: uses a stubbed fetch and fake timers. Before the fix, a ping answered 429 withRetry-After: 3600was sent on every beat (5 pings in the hour). The same happened for a dated 503 and for a week-long header past the one-day cap, and a check-in's Retry-After did not hold the ping either.desktop-update-skipped-release.test.ts: uses fakes for the macOS check and staging. Before the fix the state had no kind and the row read "Update failed — try again".topbar-ribbon-room.test.ts: cascade arithmetic over the sheet's own numbers. Before the fix, the bar was short at 481 to 502px with the ribbon drawn (481px needs 503).topbar-more-widen.test.ts:AnchoredPopoverandTopbarMoredrawn on fake-react. Before the fix, a resize with the anchor hidden moved the menu from 45px to 8px (the corner) and never closed it.AGENTS_DECK_NO_*=1, LAN state faked withpage.route):