Repository navigation
Fix the network map's layout and panel, LAN requests under dialogs, and two machine panel bugs - #1931
Merged
Merged
Conversation
The slice's name ran centred along its outer edge, and the edge stops inside the stage, so a tailnet deck on the outer ring - one remote laptop that is away, a nearby deck heard over Tailscale - had the name drawn straight through its own name and caption. The layout now says where along the edge the name goes: the middle when nothing is there, the nearest clear stretch when something is, the edge a step further out when no stretch clears, and no name at all when even that leaves none.
Below 1040px the panel stacks under the map and the stage gets short; on a phone it is 357px wide. A ring of one or two decks never moved, so a lone deck or the tailnet slice's second deck could stand under the plate with this deck's name, and a drawing that cleared neither with three rings nor with two was kept as it was. A ring of one or two may now step off the plate (and only off it). Where the slice is what keeps the names from clearing, the map is drawn without it, as it already is when every deck is on the tailnet, and where nothing clears it keeps the drawing with the fewest names on something.
The map's resting panel said "N reached over Tailscale - the shaded slice, lower right" whenever any deck was on the tailnet, but no slice is drawn when every deck on the map is, nor where the slice would leave the names no room. The panel is now told whether the slice is on screen and leaves out where to look when it is not.
With nothing pointed at, the map's panel told the reader to open a nearby deck "to ask to pair", but on a deck that pairs by invite only that deck's dialog has no Ask to pair, and the same panel pointed at the same deck already said to send an invite. The network-wide hint now takes the pairing mode and gives the invite wording, the one sentence both now share.
…its chart A press on a section's readings opens its history, and only a selection that already existed held it back. A double-click selects its word on the second press, so the first click opened the dialog and the second landed on its backdrop and closed it: nothing was selected, and the chart flashed. The readings now wait a moment for a second press before opening, and a second or third press calls the first one off. The heading still opens it at once.
…rocesses
The process table lets its name column take every pixel left over, so the
others come down to their content, and the user cell had no right padding.
A seven-digit pid, common on Linux, filled its cell and ran into the user name
("constantin1365092") on most rows. The user column now keeps 12px before the
pid, on the cells and on their headings.
A request polled in while the network map, Busiest processes, a sign-in or another panel dialog was open was drawn underneath it, since those are portalled and the request is not, yet its mount still moved focus to its Decline and made it the top of the Escape stack. Escape meant for the map put the request off, and Enter - even mid-way through typing a sign-in code - declined the other deck without anyone seeing the question. The request now waits its turn by the rule the re-sign-in prompt already follows: it is only drawn while no other dialog is up, and once up it stays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Verification
npm run typecheck: clean.--maxWorkers=3 --minWorkers=1): 846 files, 11371 tests passed, exit 0 (before the rebase). After rebasing on development, the touched and neighbouring tests were rerun: 33 files, 557 tests, all green.lan-pair-request-waits.test.ts: the request was drawn while another dialog was on the stack.network-map-slice-label.test.ts: the slice name's glyphs landed onwork-laptop/phone-tailand on 13 other stage/network cases.network-map-narrow-stage.test.ts:home-minisat on the centre's name at 920x406,work-laptopat phone width, and the finding's own roster at phone width putpi-boxonold-towerandStudio Macon the centre's name.network-map-tailnet-note.test.ts: "the shaded slice" was printed with no slice drawn.network-map-invite-only.test.ts: "Open it to ask to pair." was printed in invite mode.machine-reading-double-click.test.ts: double- and triple-clicks opened the history.process-list-user-pid-gap.test.ts: there was no padding rule at the user/pid boundary.lan-pair-request-next.test.tsnow callspairRequestFor, the pure half ofLanPairRequests.machine-reading-press.test.tsnow runs on fake timers.lan-network-map.test.ts, two cases asserted properties of layouts that never cleared. The "mostly tailnet" slice cap now uses 1+6 decks, and the dense case uses 560px./api/lanfaked throughpage.route:/api/lan/peer.15.93/15.6 GBselects it with no dialog. A single click opens the chart.