Skip to content

CI: fix the broken oneMKL cache path and drop a dead ctest exclusion #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmelnich merged 1 commit into from
Aug 13, 2026
Merged

CI: fix the broken oneMKL cache path and drop a dead ctest exclusion #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/actions/setup-randlapack-deps-windows/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,17 @@ runs:
# install-script workflow checks this repo out under RandLAPACK\, where
# the glob matches nothing and hashFiles() silently returns "" -- the two
# workflows then read/write DIFFERENT caches while appearing to share.
# The version in `path` must match $mklVersion in setup.ps1, which is what
# names the directory it creates. It did not: the path still said
# 2025.2.0.627 after the bump to 2026.1.0.226, so it pointed at a directory
# that never exists. That fails quietly in the worst way -- every MKL leg
# re-downloaded 155 MB and then saved a cache entry for a missing path, so
# the cache could never hit and nothing ever reported an error.
- name: cache oneMKL (NuGet)
if: inputs.blas-backend == 'mkl'
uses: actions/cache@v4
with:
path: ${{ github.workspace }}\..\windows-deps\onemkl-2025.2.0.627
path: ${{ github.workspace }}\..\windows-deps\onemkl-2026.1.0.226
key: windows-nuget-intel-mkl-2026.1.0.226-r1

- name: cache OpenBLAS (release binaries)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/core-linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
`pwd`/../RandLAPACK
make -j$(nproc)
make -j$(nproc) install
ctest --exclude-regex "^TestABRIK\.ABRIK_catch_instability" --output-on-failure
ctest --output-on-failure

- name: build and test extras
run: |
Expand Down Expand Up @@ -208,4 +208,4 @@ jobs:
`pwd`/../RandLAPACK
make -j$(nproc)
make -j$(nproc) install
ctest --exclude-regex "^TestABRIK\.ABRIK_catch_instability" --output-on-failure
ctest --output-on-failure
4 changes: 2 additions & 2 deletions .github/workflows/core-macos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
## RUN below, so its result is not lost: if it starts PASSING, the ##
## job prints a loud warning telling you to delete this block. ##
#####################################################################
ctest --exclude-regex "^TestABRIK\.ABRIK_catch_instability|^TestQB\.Polynomial_Decay_general1" \
ctest --exclude-regex "^TestQB\.Polynomial_Decay_general1" \
--output-on-failure
echo "::warning title=TEMPORARY macOS suppression is ACTIVE::TestQB.Polynomial_Decay_general1 is quarantined (Apple Accelerate gesdd bug). REVERT once Mark has reviewed the BLAS++/LAPACK++ Accelerate migration. See docs/CI.md."
if ctest --tests-regex "^TestQB\.Polynomial_Decay_general1" --output-on-failure; then
Expand Down Expand Up @@ -228,7 +228,7 @@ jobs:
## RUN below, so its result is not lost: if it starts PASSING, the ##
## job prints a loud warning telling you to delete this block. ##
#####################################################################
ctest --exclude-regex "^TestABRIK\.ABRIK_catch_instability|^TestQB\.Polynomial_Decay_general1" \
ctest --exclude-regex "^TestQB\.Polynomial_Decay_general1" \
--output-on-failure
echo "::warning title=TEMPORARY macOS suppression is ACTIVE::TestQB.Polynomial_Decay_general1 is quarantined (Apple Accelerate gesdd bug). REVERT once Mark has reviewed the BLAS++/LAPACK++ Accelerate migration. See docs/CI.md."
if ctest --tests-regex "^TestQB\.Polynomial_Decay_general1" --output-on-failure; then
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/install-script.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ jobs:
- name: test the installed library
run: |
ctest --test-dir RandNLA-project/build/RandLAPACK-build \
--exclude-regex "^TestABRIK\.ABRIK_catch_instability" \
--output-on-failure

- name: re-run the installer in place (idempotency)
Expand Down Expand Up @@ -113,7 +112,6 @@ jobs:
- name: test the installed library
run: |
ctest --test-dir RandNLA-project/build/RandLAPACK-build \
--exclude-regex "^TestABRIK\.ABRIK_catch_instability" \
--output-on-failure

- name: re-run the installer in place (idempotency)
Expand Down
Loading