Support v4 Multi-Bucket Application Keys#30
Open
johnmaguire wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27 with the ultimate goal of solving restic/restic#5741
A new b2.CreateKeyMultiBucket was added to avoid breaking the type signature of b2.CreateKey, with support for multi-bucket application keys.
b2.CreateKey continues to use the old API (similar to the terraform provider's usage of
bucket_idvsbucket_ids) in order to support clients which do not support multi-bucket application keys.Client.CreateKey accepts a new BucketIDs option and selects CreateKeyMultiBucket when len(bucketIDs) > 1.
References:
b2-sdk-pythonPR #538 (the porting reference):<Add support for multi-bucket application keys b2-sdk-python#538terraform-provider-b2v0.12.1 (per-call v3/v4 dispatch): https://github.com/Backblaze/terraform-provider-b2/releases/tag/v0.12.1