Repository navigation
chore(lint): apply py312 pyupgrade fixes to seo_manager and drop the temporary ignores - #47
Merged
Merged
Conversation
…temporary ignores
joepetjr
added
the
needs-operator
Contributor
Author
|
Hard-denied (hard-deny: protected path family) and ready to merge -- all checks green. Offending paths:
Human merge: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#44 moved Waypost to Python 3.12 and left a temporary per-file-ignores entry in
pyproject.tomlso the move stayed small:"seo_manager/**/*.py" = ["UP006","UP007","UP017","UP035","UP045","B905","I001"]. This PR applies those fixes and deletes the entry and its comment.Change
ruff check seo_manager --fix: 811 safe fixes (List/Dict/Optional/Unionto builtin andX | Noneforms,datetime.UTC,collections.abcimports, import sorting).zip()calls getstrict=False, which keeps today's behaviour (no new length check).seo_manager/analytics/final_text_surfaces.py: theParttype alias is nowPlaceLine | TemplateBlock | Chapter | Tag | ParamBlock.ruff format seo_manageron the 13 touched files.49 files, +677/-705 (net -28). No behaviour change intended.
Tests
ci/tools-requirements.txt, 0.15.22):ruff check .clean,ruff format --check .clean (172 files).