Repository navigation
fix(qcm): put the last seven map reads on fetchWithDeadline - #38
Merged
Merged
Conversation
address-geocode.js and the six source-* modules (avalanche, nrhp, ntad-rail-airports, nws-observations, snotel, stream-gauges) made their own raw fetch calls with no deadline from request.js. Each now reads through fetchWithDeadline at its source's registry timeoutMs (the geocoder keeps its 10 s), keeping its public signature and failure value. no-raw-fetch's ALLOW list is empty and adapter-deadlines has a row per module.
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37: the last seven map modules that still made their own raw
fetch(calls now go throughrequest.jsfetchWithDeadline, so every remote read in the map has a deadline and a cancel.Modules (
themes/headlessmode/static/js/quiet-corners-maps/):address-geocode.js,source-avalanche.js,source-nrhp.js,source-ntad-rail-airports.js,source-nws-observations.js,source-snotel.js,source-stream-gauges.js. Public signatures and failure values are unchanged;fetchImplstays injectable.geocodeAddresskeeps every status (ready, none, bad-query, rate-limited, timeout, unavailable, aborted).Guards:
scripts/qcm/no-raw-fetch.test.mjs:ALLOWis now empty.scripts/qcm/adapter-deadlines.test.mjs:pendingremoved; eight new deadline and abort rows (geocode, avalanche zone store, NRHP, rail, airports, observations, SNOTEL, gauges), plus a deadline test for the twoloadCataloguereads.scripts/qcm/README.mdno longer lists the exceptions.Verification:
node --test scripts/qcm/*.test.mjswith the site built: 3002 pass / 14 fail. All 14 wereno free browser slot in /tmp/qcm-browser-slots after 300000 ms(the box's Chromium slots were taken by other runs), not assertions.--test-concurrency=1: 81/81 pass.