Skip to content

Conversation

@karllark
Copy link
Member

@karllark karllark commented Oct 18, 2019

Adding evolutionary tracks in as an option. Joins the current only option of isochrones.
The idea is that for single star SED fitting, evolutionary tracks may may allow for a better sampling of the physical parameter space with fewer points. To be determined.

Closes #267.
Closes #18.
Closes #419.

Manual rebase from PR #284 (too many conflicts to auto rebase easily).

@karllark karllark added the stars label Oct 18, 2019
@karllark karllark added this to the BEAST v2.0 milestone Oct 18, 2019
@coveralls
Copy link

coveralls commented Oct 18, 2019

Coverage Status

Coverage decreased (-0.6%) to 42.027% when pulling 0cf679c on karllark:add_evol_tracks into 21e363b on BEAST-Fitting:master.

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2019

This pull request introduces 1 alert when merging 28616e4 into 21e363b - view on LGTM.com

new alerts:

  • 1 for Missing call to __init__ during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2019

This pull request introduces 1 alert when merging 0cf679c into 81d5080 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@karllark
Copy link
Member Author

Getting this working again.

Recovered how to generate the MIST fits files from the ascii files downloaded from the MIST website (https://waps.cfa.harvard.edu/MIST/model_grids.html#eeps).

Update the evolutionary track plots to give more information about the regridding. An example in the next comment.

@karllark
Copy link
Member Author

MIST evoltracks for feh=p0.00. Black is as downloaded. Blue is regridded to uniform logM and condensed with to remove points w/ less than the deltas given as computed along a single mass evolutionary track.

(base) [kgordon@dirty MIST]$ python ~/Python/beast/beast/plotting/plot_evoltracks.py MIST_FeH0.00.fits --condense 
size orig =  259827
size regrid =  14719
logM range: [-1.0, 3.0]
logM: 0.05
condense: True
condense deltas
logT: 0.05
logL: 0.05
grid metrics: diffs [min,  max, median, mean]
logL
  orig: [3.435018935959988e-10, 0.2862267761637278, 0.008897551923432001, 0.013521154589942302]
regrid: [5.578930625471656e-06, 0.23607140365266965, 0.03816796642929332, 0.03599822784774602]
logT
  orig: [9.128076072784097e-11, 0.29449549130961605, 0.0018497452251660107, 0.0029010444414949966]
regrid: [2.6497791516533198e-08, 0.3071999709304931, 0.00470920031562283, 0.010666433098119679]
logg
  orig: [4.949631815520661e-10, 1.0909475227034098, 0.015412822012143668, 0.02205363698970596]
regrid: [1.2148029982561592e-05, 1.1488386623502533, 0.05239822156450702, 0.06607721382890888]

evoltracks

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

❌ Patch coverage is 19.57831% with 267 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.20%. Comparing base (78aa53b) to head (eeffa6c).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
beast/physicsmodel/stars/evoltracks.py 13.41% 142 Missing ⚠️
beast/plotting/plot_evoltracks.py 7.14% 52 Missing ⚠️
beast/physicsmodel/stars/isochrone.py 9.09% 30 Missing ⚠️
beast/plotting/plot_isochrones.py 15.38% 22 Missing ⚠️
beast/tools/verify_beast_settings.py 23.07% 10 Missing ⚠️
beast/physicsmodel/model_grid.py 65.38% 9 Missing ⚠️
beast/physicsmodel/dust/extinction_extension.py 91.66% 1 Missing ⚠️
beast/tools/run/create_physicsmodel.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   41.98%   41.20%   -0.79%     
==========================================
  Files         108      111       +3     
  Lines       10302    10609     +307     
==========================================
+ Hits         4325     4371      +46     
- Misses       5977     6238     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karllark
Copy link
Member Author

Current usual star fit results as comparable to the one shown in the docs.

Very similar to the updated padova cmd plot shown in PR #839.

beast_metal_small_ifit_starnum_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics for physicsmodel grid quality Add evolutionary tracks as a 2nd option for generating the stellar grid

2 participants