Skip to content

Fix volunteer RSVP language in non-RSVP event#1667

Open
Meatchema wants to merge 14 commits intodevelopmentfrom
issue-1663-change-rsvp-language
Open

Fix volunteer RSVP language in non-RSVP event#1667
Meatchema wants to merge 14 commits intodevelopmentfrom
issue-1663-change-rsvp-language

Conversation

@Meatchema
Copy link
Contributor

@Meatchema Meatchema commented Jan 22, 2026

Issue Description

Fixes #1663
For events that are not expecting RSVP, we need to change our language to 'Invited' students, if people are added ahead of time. Wherever we display those RSVP students, both before and after the event, should reflect this change.

Changes

  • Created the invitedUser variable in Volunteer.py, also used in VolunteerDetails.html
  • Added time restraints to the invitedUser variable and attendedUser variable so that the code could differentiate between them based on whether the student joined before or after the event. (Also adjusts so that if the event starts, they are considered attended)

New Changes (2/9/26)

  • Removed the invitedUser variable in Volunteer.py, also used in VolunteerDetails.html
  • Removed time restraints to the invitedUser variable and attendedUser variable .
  • Added condition to tables under 'manage volunteers' and 'volunteer details' that would check if RsvpRequired was required or not. This resulted in 'invited' only showing on the tables within a Non-RSVP event and 'RSVP' only showing on the tables within a RSVP event.
  • changed eventVolunteerData to include non-waitlist RSVP's so that the manage volunteer table can see ALL the volunteers added to the event

Testing

  • Go to "Settings" under the "Admin" tab
  • Click on the "Term Management" drop down section
  • Click on the most recent year and then click add new term (Repeat until you can click on Spring 2026)
image

Under "Create Events":

  • Create two events of any type with under admin permissions (one event needs to have RSVP and the other shouldn't)
  • They both need to have a date after your current day (nothing on or before your current date in real life)
  • Switch to student and sign up for both events:
    Note: To add the student to the non-RSVP event:
    - retrieve the student's B# from their profile
    - Switch back to Brian's Admin Profile
    - Go to event's list and click on the non-Rsvp event
    - Click on Manage Volunteers, click Scanner Entry, then past the B#
    - This should result in the 'Invited' status in a non-RSVP event, and 'RSVP' status on a RSVP Event.
  • Once you go to "Volunteer Details", within "Events List", you will see that the student has been added as well as their status
  • Look at the table view, under volunteer status, the student will either be "RSVP", "Invited", "Waitlisted, or "Attended"
image

Note (UPDATED-2/9/26):
RSVP- A person who registered for an RSVP event online
Attended- An RSVP individual entered manually through Barcode to an RSVP event
Invited- An individual manually added to a non-RSVP event (using name search)
Waitlisted- A person who registered for the event after the RSVP limit was reached

The creation of these two previous events is to make sure that' RSVP' shows up under the RSVP event and 'Invited' shows up for the non-RSVP event. The ATTENDED status will only show if entered through the barcode. This is because the barcode and B# scanner is only used during and at the start of school events meaning the student is already there. Now you will create the third.

… not rsvp and have attended and or have not attended
@Meatchema Meatchema self-assigned this Jan 22, 2026
@Meatchema Meatchema marked this pull request as draft January 22, 2026 21:56
@Meatchema Meatchema marked this pull request as ready for review January 28, 2026 19:35
@bakobagassas bakobagassas self-requested a review January 28, 2026 20:03
Copy link
Contributor

@bakobagassas bakobagassas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-rsvp events, when we manually add a volunteer using the scanner, they show as invited however, when we manually add them using their names they show as RSVP and not invited. It should be consistent when the event is non-rsvp whether we use the name search or scanner, we should have always have Invited instead of RSVP

Image

Copy link
Contributor

@bakobagassas bakobagassas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people entered through the scanner thingy don't show up in manage volunteers, only in volunteers list. They should show up in both normally

Image

@Meatchema Meatchema requested a review from Kafui123 February 13, 2026 20:36
@Kafui123
Copy link
Contributor

image I think that under the volunteer status "waitlisted" might read more naturally instead of "waitlist"


{% macro createCheckbox(checkboxName) %}
{% set labelText = "RSVP" if checkboxName == 'rsvp' else 'Waitlist' if checkboxName == 'waitlist' else 'Attended' %}
{% set labelText = "RSVP" if checkboxName == 'rsvp' else 'Waitlist' if checkboxName == 'waitlist' else 'Attended' if checkboxName == 'attended' else 'Invited' %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think using a dictionary mapping here might be cleaner i.e

{ % set labels = {
'rsvp' : "RSVP" } %}

{ % set labelText = labels.get (checkboxName, "invited") %} something like this might make the code more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now fix change this line to a dictionary and changed instances of waitlist to "waitlisted".

@RueHaile RueHaile self-requested a review February 16, 2026 21:09
@github-actions
Copy link

View Code Coverage

@Meatchema Meatchema requested a review from Kafui123 February 17, 2026 20:41
@RueHaile
Copy link
Contributor

In my opinion, it makes more sense as an admin to be able to invite certain students to a non rsvp program and for it to display as invited regardless of the entry method, be it through "scan entry" or through "add volunteers."

@Meatchema
Copy link
Contributor Author

In my opinion, it makes more sense as an admin to be able to invite certain students to a non rsvp program and for it to display as invited regardless of the entry method, be it through "scan entry" or through "add volunteers."

Good Afternoon, I was informed by Brian that anytime that a user is entered via Barcode the result should always be attended since the barcode scanner is only used at the start of an event. It is never used significantly before the event actually happens, so it does not qualify for invited or RSVP status. I will however try to ask Brian to check in on this to make sure this is the final product that was aimed for.

@RueHaile
Copy link
Contributor

In my opinion, it makes more sense as an admin to be able to invite certain students to a non rsvp program and for it to display as invited regardless of the entry method, be it through "scan entry" or through "add volunteers."

Good Afternoon, I was informed by Brian that anytime a user is entered via barcode, the result should always be attended since the barcode scanner is only used at the start of an event. It is never used significantly before the event actually happens, so it does not qualify for invited or RSVP status. I will, however, try to ask Brian to check in on this to make sure this is the final product that was aimed for.

No need, I just wanted to make sure that there is a reason behind the logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change RSVP to Invited for non-RSVP events

4 participants

Comments